• paul@techy.news
    link
    fedilink
    English
    arrow-up
    10
    arrow-down
    2
    ·
    1 year ago

    do git commit -v and then just summarize the diff you have in your editor in a human readable form.

    • DontTakeMySky@lemmy.world
      link
      fedilink
      arrow-up
      10
      ·
      1 year ago

      Don’t just summarize the content though, summarize the rationale or how things connect. I can read your diff myself to see what changed, I want to know the logical connections, the reason you did X and not Y, etc.

      Or just say “stuff” and provide that context in the PR description separately, no need to overdo the commit log on a feature branch if you’re using squash merges from your PR.

      • deadbeef79000@lemmy.nz
        link
        fedilink
        arrow-up
        8
        ·
        edit-2
        1 year ago

        P1000x this.

        I can read a diff.

        I need to know why.

        No, a code comment isn’t good enough, it’s out of date after the next commit.

        • DontTakeMySky@lemmy.world
          link
          fedilink
          arrow-up
          1
          ·
          1 year ago

          Code comments for "why"s that persist. Commits for why’s that are temporary.

          If you need to run X before Y, add a comment. If you added X before why because it was easier, leave it in a commit